Changeset 886307f for fedd/federation/experiment_control.py

Timestamp:

Jul 28, 2009 3:42:17 PM (15 years ago)

Author:

Ted Faber <faber@…>

Branches:

axis_example, compt_changes, info-ops, master, version-1.30, version-2.00, version-3.01, version-3.02

Children:

d9987ad

Parents:

9479343

Message:

better subprocess output containment

File:

• fedd/federation/experiment_control.py (modified) (3 diffs)

fedd/federation/experiment_control.py

@@ -555 +555 @@
 
             try:
-                dnull = open("/dev/null", "r")
+                dnull = open("/dev/null", "w")
             except IOError:
                 self.log.debug("[ssh_cmd]: failed to open /dev/null " + \
@@ -996 +996 @@
                     "Failed to open file in genviz")
 
+        try:
+            dnull = open('/dev/null', 'w')
+        except IOError:
+            service_error(service_error.internal,
+                    "Failed to open /dev/null in genviz")
+
         # Generate a dot/neato input file from the links, nodes and lans
         try:
@@ -1016 +1022 @@
         # Use dot to create a visualization
         dot = Popen([neato, '-Gstart=rand', '-Gepsilon=0.005', '-Gmaxiter=2000',
-                '-Gpack=true', dotname], stdout=PIPE, close_fds=True)
+                '-Gpack=true', dotname], stdout=PIPE, stderr=dnull,
+                close_fds=True)
+        dnull.close()
 
         # Translate dot to vis format