Changeset 9c73557 for fedd

Timestamp:

Apr 7, 2011 7:10:47 AM (14 years ago)

Author:

Ted Faber <faber@…>

Branches:

compt_changes, info-ops, master

Children:

37ecf7e

Parents:

8f1db21

Message:

apply_to_tags miscoded for multiple applications of the map. Basic python stuff. This is from when I was learning.

File:

• fedd/federation/remote_service.py (modified) (2 diffs)

fedd/federation/remote_service.py

@@ -61 +61 @@
     # A map used to convert fedid fields to fedid objects (when the field is
     # already a string)
-    fedid_to_object = ( ('fedid', lambda x: fedid(bits=x)),)
+    fedid_to_object = {'fedid': lambda x: fedid(bits=x)}
     # A map used by apply_to_tags to convert fedids from xmlrpclib.Binary
     # objects to fedid objects in one sweep.
-    decap_fedids = (('fedid', lambda x: fedid(bits=x.data)),)
+    decap_fedids = {'fedid': lambda x: fedid(bits=x.data), 
+            'credential': lambda x: x.data}
     # A map used to encapsulate fedids into xmlrpclib.Binary objects
-    encap_fedids = (('fedid', to_binary),)
+    encap_fedids = {'fedid': to_binary, 'credential': to_binary}
 
     # fields that are never unicoded, because they represent non strings.
@@ -142 +143 @@
         if isinstance(e, dict):
             for k in e.keys():
-                for tag, fcn in map:
-                    if k == tag:
-                        if isinstance(e[k], list):
-                            e[k] = [ fcn(b) for b in e[k]]
-                        else:
-                            e[k] = fcn(e[k])
-                    elif isinstance(e[k], dict):
-                        remote_service_base.apply_to_tags(e[k], map)
-                    elif isinstance(e[k], list):
-                        for ee in e[k]:
-                            remote_service_base.apply_to_tags(ee, map)
+                if k in map:
+                    fcn = map[k]
+                    if isinstance(e[k], list):
+                        e[k] = [ fcn(b) for b in e[k]]
+                    else:
+                        e[k] = fcn(e[k])
+                elif isinstance(e[k], dict):
+                    remote_service_base.apply_to_tags(e[k], map)
+                elif isinstance(e[k], list):
+                    for ee in e[k]:
+                        remote_service_base.apply_to_tags(ee, map)
         # Other types end the recursion - they should be leaves
         return e