Changeset 66a8e6d

Timestamp:

Nov 19, 2010 12:10:06 PM (14 years ago)

Author:

Ted Faber <faber@…>

Branches:

axis_example, compt_changes, info-ops, master

Children:

547aa3b

Parents:

881cd02

Message:

be marginally more careful about file permissions.

File:

• fedkit/smbmount.Linux.pl (modified) (1 diff)

fedkit/smbmount.Linux.pl

@@ -61 +61 @@
         my $ids = $FSTYPE == 'smbfs' ? ",uid=$uid,gid=$gid" : "";
 
+        #We should be even more careful about creating these files securely,
+        #confirming ownership, etc., but this is run in an restricted
+        #environment.
         open(PWDFILE, ">/tmp/$user.cifs_creds") || 
             warn "Can't create credentials for $user:$!\n";
-        print PWDFILE "username=$user\npassword=$pswd\n";
-        close(PWDFILE);
         chmod(0600, "/tmp/$user.cifs_creds") == 1 || 
             warn "Credential file /tmp/$user.cifs_creds may have " .
                 "bad permissions:$!\n";
+        print PWDFILE "username=$user\npassword=$pswd\n";
+        close(PWDFILE);
 
         print FSTAB "//$SHARE/$user\t";